Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/hooks/desktop-file-utils: document hook #341280

Merged
merged 1 commit into from
Oct 6, 2024
Merged

doc/hooks/desktop-file-utils: document hook #341280

merged 1 commit into from
Oct 6, 2024

Conversation

tomodachi94
Copy link
Member

@tomodachi94 tomodachi94 commented Sep 12, 2024 •
edited
Loading

Description of changes

Documented the hook included with desktop-file-utils (which removes the mimeinfo.cache file sometimes created when using the aforementioned tools), which was added in #55465.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94
Copy link
Member Author

tomodachi94 commented Sep 12, 2024 •
edited
Loading

Requesting a review from @worldofpeace, who authored the initial PR. Unfortunately, it looks like they stopped being active on GitHub around a quarter into 2021.

@tomodachi94 tomodachi94 added the backport release-24.05 Backport PR automatically label Sep 12, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 12, 2024
@tomodachi94
Copy link
Member Author

Tracking: #341479

@tomodachi94 tomodachi94 added the 5. scope: tracked Issue (or PR) is linked back to a `5. scope: tracking` issue label Sep 13, 2024
@pbsds pbsds merged commit 8cf4396 into NixOS:master Oct 6, 2024
32 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Oct 6, 2024
Merged
1 task
@tomodachi94 tomodachi94 deleted the enhance/doc/hooks/desktop-file-utils branch October 6, 2024 17:41
@tomodachi94 tomodachi94 mentioned this pull request Oct 25, 2024
Open
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds pbsds approved these changes

Assignees
No one assigned
Labels
5. scope: tracked Issue (or PR) is linked back to a `5. scope: tracking` issue 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomodachi94 @pbsds